Make title row of generated CSV file have correct number of columns #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdoupe
reviewed
Jun 14, 2018
| } | ||
| var commas = (output_.split('\n')[0].match(/,/g) || []).join(''); | ||
| var output = '"' + str + '"' + commas + '\n' + output_; | ||
|
|
||
| var url = window.location.href; |
There was a problem hiding this comment.
@lucassz I'm having trouble figuring out what's going on here. Would you mind adding a comment or two?
There was a problem hiding this comment.
Added now, hope that's clearer. The first line is substantially different from the last line because the first line is a caption, whereas the last line actually is part of the body of the table. This manually makes it as though the caption were another row.
|
LGTM. Thanks @lucassz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #885. It may be that the minified file has to be updated too, although I'm not sure if it's actually being used.