Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add special HTML pages for when a model result is not found or is incompatible #874

Merged
merged 4 commits into from
Mar 28, 2018

Conversation

GoFroggyRun
Copy link
Contributor

This PR tries to close #869. Two HTML pages are added to TB and CCC respectively, where the content of the page suggest an option to re-create outdated results.

@GoFroggyRun
Copy link
Contributor Author

GoFroggyRun commented Mar 27, 2018

Here's a preview for TB version:
screen shot 2018-03-27 at 5 41 15 pm

@hdoupe could you take a look at these pages? Feel free to modify the content if you'd like.

Do you find these pages sufficient for you to render in view.py?

@GoFroggyRun
Copy link
Contributor Author

I also noted that CCC and TB are sharing the same header: see here. Does it make sense to break TB's header into two pieces, one for TB and the other for CCC, and place them in their respective directories?

@hdoupe
Copy link
Collaborator

hdoupe commented Mar 28, 2018

@GoFroggyRun these look good. I think we can go ahead and merge this. I'll update the back-end so that these pages are rendered on exceptions. I'll also tweak the language some. Thanks for the quick response on this PR.

I think it does make sense to break up the headers. Would you mind opening a separate PR to do this? There's a lot of apps referencing code in other apps in both in the front-end and in the back-end. I think it's a good idea to draw a clear line between the different apps and pull the shared code into a central place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants