ST' needs payable Initialize() to accept all base tokens #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminbollen
added a commit
that referenced
this pull request
Nov 24, 2017
benjaminbollen
added a commit
that referenced
this pull request
Nov 24, 2017
benjaminbollen
force-pushed
the
benjaminbollen/gh6/STP-Initialize
branch
from
53fb298
to
276508c
Compare
jasonklein
reviewed
Nov 24, 2017
| */ | ||
| /// set when ST' has received TOKENS_MAX tokens; | ||
| /// when uninitialised minting is not allowed | ||
| bool private initialized; |
There was a problem hiding this comment.
because I felt it should not be exposed / considered for ST' to ever be un-initialised; if ST' is not yet initialised the utility chain is not even worth considering for adding as a Core
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hold off until #5 is merged
before the registrar registers a core on the value chain it must verify that the genesis exactly specified TOKENS_MAX so that all base tokens are held by STPrime.
added modifier
onlyInitializedtoclaim,mint,burnon STPrime.solfixes #6