Admin initiate and revoke protocol transfer #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and OpenSTUtility. Addresses #36
benjaminbollen
commented
Dec 12, 2017
contracts/OpenSTUtility.sol
Outdated
| * Administrative functions | ||
| */ | ||
| function initiateProtocolTransfer( | ||
| // including ProtocolVersioned interface explicitly adds to the size |
There was a problem hiding this comment.
I'll need to change this comment
jasonklein
suggested changes
Dec 12, 2017
| onlyAdmin | ||
| returns (bool) | ||
| { | ||
| _token.initiateProtocolTransfer(_proposedProtocol); |
There was a problem hiding this comment.
Need to explicitly return, otherwise will always return false. This comment applies to the identically-named function in OpenSTValue.sol as well.
| onlyAdmin | ||
| returns (bool) | ||
| { | ||
| _token.revokeProtocolTransfer(); |
There was a problem hiding this comment.
Need to explicitly return, otherwise will always return false. This comment applies to the matching function in OpenSTValue.sol as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable a very simple form of protocol transfer to begin with on 0.9.1 OpenSTValue and OpenSTUtility to transfer protocol. Addresses #36