Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use x/tools/go/analysis #26

Closed
ldez opened this issue Aug 21, 2022 · 4 comments
Closed

Update to use x/tools/go/analysis #26

ldez opened this issue Aug 21, 2022 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@ldez
Copy link
Contributor

ldez commented Aug 21, 2022

Hello,

The project still uses the deprecated golang.org/x/tools/go/loader instead of golang.org/x/tools/go/analysis.

https://github.com/golang/tools/blob/587a15310bddfc939d37cfaa8be8ea4c3808c3f1/go/loader/doc.go#L10-L11

Do you plan to migrate to golang.org/x/tools/go/analysis?
Do you need help?

@dixonwille
Copy link
Member

Help is always welcome. I no longer use this tool as the stack I work in daily no longer includes Go :( If I can find the time I will take look into it.

@dixonwille
Copy link
Member

https://github.com/OpenPeeDeeP/depguard/blob/feature/v2/v2/depguard.go started working on it. While digging into it, it was not a backwards compatible change. So I figured out I need to start looking at a V2 variant. Will be defining exactly what that means later this week. Feel free to offer ideas here until I create a V2 issue, milestone, etc.

@dixonwille dixonwille added this to the V2 milestone Aug 30, 2022
@dixonwille
Copy link
Member

So I have a working beta v2.0.0-beta.2

go install github.com/OpenPeeDeeP/depguard/v2/cmd/depguard@v2.0.0-beta.2

I have tested on a few repositories. But would like others to try it out to.

@dixonwille
Copy link
Member

I have just released version 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants