Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Developers] Standardize on PF2GameplayAbilityUtilities::GetTag() or FGameplayTag::RequestGameplayTag() #59

Open
GuyPaddock opened this issue Dec 27, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers tech debt

Comments

@GuyPaddock
Copy link
Contributor

As a Developer maintaining OpenPF2, I'd like it if C++ code that works with gameplay tags would standardize on using either PF2GameplayAbilityUtilities::GetTag() or FGameplayTag::RequestGameplayTag() but not both so that code behaves uniformly and is easier to maintain.

Conditions of Acceptance

Given I'm looking at C++ code that needs to request a gameplay tag:

  1. I'd expect all the code to use either PF2GameplayAbilityUtilities::GetTag() or FGameplayTag::RequestGameplayTag().
  2. I'd expect to not find any code using the opposite (outside of the utility method upon which we've standardized).
@GuyPaddock GuyPaddock added enhancement New feature or request good first issue Good for newcomers tech debt labels Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers tech debt
Projects
None yet
Development

No branches or pull requests

1 participant