We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The try/except is not needed.
https://github.com/NextThought/nti.externalization/blob/907b3cda5b0121d42e2463503c57fe9a262f1ba9/src/nti/externalization/_interface_cache.py#L50-L57
Also, there's a subtle race-condition here if anyone tries to use _v_attrs later, as _make_modified_attributes does.
_v_attrs
_make_modified_attributes
https://github.com/NextThought/nti.externalization/blob/907b3cda5b0121d42e2463503c57fe9a262f1ba9/src/nti/externalization/internalization/events.py#L55-L60
This low-level method should also return the _v_attrs dict (and maybe the providedBy object) it's using to avoid this.
providedBy
The text was updated successfully, but these errors were encountered:
That race condition bites us because of zopefoundation/zope.container#38
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
The try/except is not needed.
https://github.com/NextThought/nti.externalization/blob/907b3cda5b0121d42e2463503c57fe9a262f1ba9/src/nti/externalization/_interface_cache.py#L50-L57
Also, there's a subtle race-condition here if anyone tries to use
_v_attrs
later, as_make_modified_attributes
does.https://github.com/NextThought/nti.externalization/blob/907b3cda5b0121d42e2463503c57fe9a262f1ba9/src/nti/externalization/internalization/events.py#L55-L60
This low-level method should also return the _v_attrs dict (and maybe the
providedBy
object) it's using to avoid this.The text was updated successfully, but these errors were encountered: