Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default instrument to select when NBS is opened #494

Open
CreeperPookie opened this issue Dec 16, 2024 · 3 comments
Open

Set a default instrument to select when NBS is opened #494

CreeperPookie opened this issue Dec 16, 2024 · 3 comments
Labels
C: Enhancement New feature or request

Comments

@CreeperPookie
Copy link

Is your feature request related to a problem? Please describe.
I've noticed that when NBS is opened, the selected instrument is always set to harp by default. However, this does make a lot of sense (harp is the default Minecraft note block instrument, and does sound very similar to a piano), there have been many times I wished it started on another kind, especially if I want to play along or record note timings for a song.

Describe the enhancement you'd like
One thing that could be done is to add a settings entry for a default instrument (perhaps a dropdown-like menu, similarly for the theme or max frame rate setting) and set the current instrument to that when NBS is opened; a default custom instrument would be very nice, though I realize that would not be easy since custom instruments are only loaded after opening a specific song that requires it.

Additional context
One effect this would have would be effectively setting the default instrument for a MIDI keyboard without entering the MIDI settings. Although I know you can override the MIDI instrument on a per-keyboard basis, it isn't saved and is reset upon reopening NBS. One thing I have run into regarding this is trying to play notes during a song with the keyboard or a MIDI device, especially in player mode; for a lot of the songs I've made and/or listened to, Harp is way too soft to hear, especially in the lower octaves. Changing to Pling helps a lot with this, though if I'm listening to something in player mode (especially to see how a song looks in drop mode), this just isn't possible and it becomes a lot trickier to hear the notes I play.

@Bentroen
Copy link
Member

Bentroen commented Dec 16, 2024

If I understand correctly, you'd like a dropdown to pick the instrument that's selected by default when you open NBS?
While I see how that would be useful in your case, it's a great deal of maintenance burden to add to the app for something that would only save a single click :)

Although I know you can override the MIDI instrument on a per-keyboard basis, it isn't saved and is reset upon reopening NBS.

Perhaps that would be a more useful addition? The biggest challenge with it is identifying which instrument is which over different sessions (the order they're plugged in could change). I suppose it would be possible to use its display name as an identifier.

@Bentroen Bentroen added the C: Enhancement New feature or request label Dec 16, 2024
@OctoFlareDev
Copy link
Collaborator

maybe add this in a drop down menu when right clicking instrument icons

@CreeperPookie
Copy link
Author

CreeperPookie commented Dec 16, 2024

If I understand correctly, you'd like a dropdown to pick the instrument that's selected by default when you open NBS? While I see how that would be useful in your case, it's a great deal of maintenance burden to add to the app for something that would only save a single click :)

well the dropdown specifically was just an example, but it's only way I can think to acomplish right know lol

Although I know you can override the MIDI instrument on a per-keyboard basis, it isn't saved and is reset upon reopening NBS.

honestly the MIDI keyboard would just be a side effect of setting a default instrument, since its default option is use selected instrument; very useful for sure, though setting the selected editor instrument also can accomplish this (though I realize why some people might not want to have their piano always default to their selected editor instrument!)

Perhaps that would be a more useful addition? The biggest challenge with it is identifying which instrument is which over different sessions (the order they're plugged in could change). I suppose it would be possible to use its display name as an identifier.

yeah that's a fair point, though I think storing by display name is the only real possibility (apparently MIDI devices they don't even have a real unique ID at all)
Even if you tried using querying every possible attribute of the MIDI device and using that as an identity, I imagine it would leave a lot of scenarios where two MIDI devices are indistinguishable from each other (especially if the user has two of the same model of MIDI device)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants