Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consuming a RESTful web service with Angular 7 #264

Closed
realModusOperandi opened this issue Apr 22, 2019 · 17 comments
Closed

Consuming a RESTful web service with Angular 7 #264

realModusOperandi opened this issue Apr 22, 2019 · 17 comments
Assignees
Labels
contribution dev content reviewed the content of the guide has been reviewed by committer final content reviewed final content review before publishing final end-to-end test completed the guide was verified from end to end ID reviewed new guide peer reviewed the guide has been peer reviewed signed off the guide can proceed to publishing SME reviewed the guide has been reviewed by SME target:ga user reviewed the guide has been reviewed by an end user

Comments

@realModusOperandi
Copy link

Is there any interest in an Angular 7 version of "Consuming a RESTful web service with AngularJS"? When I first started an Angular application that consumed an endpoint from OpenLiberty I found that guide but couldn't apply it since it was AngularJS and the two are quite different.

Now that I have completed that app I experimented with converting it to modern Angular and I think it could work: https://github.com/realModusOperandi/guide-rest-client-angularjs/tree/angular7 I have written the start and finish code and have taken a stab at writing the guide text to give an idea of what would need to be discussed.

I think there's value in doing this because AngularJS is stabilized and Angular has surpassed it in userbase, and because creating a project that builds both an Angular frontend and OpenLiberty app backend requires some work to set up and this guide could provide users with a decent starting point for achieving that (the start directory already has the default Angular app generated, the pom file set up to build it, etc.)

@evelinec
Copy link
Contributor

@yeekangc @gkwan-ibm FYI.

@yeekangc
Copy link
Member

@realModusOperandi, I would think we would be open to contribution. If you are open to take what you have a few steps further and turn it into a draft guide, we can go from there.

@evelinec
Copy link
Contributor

evelinec commented Apr 24, 2019

Hi Liam, thank you for your contributing a guide. The team has reviewed this topic and decided to accept it as a new guide! I encourage you to go through our guide's template here, especially take a look at the Guidelines for Structure and Styles wiki.

When you're ready, you can create a PR to a draft-guide repo we had created for you. @realModusOperandi

Here's a repo we created in the OpenLiberty project for this guide, you can create a PR from your personal repo to this one against the dev branch: https://github.com/OpenLiberty/draft-guide-rest-client-angular. We will then start the review processes.

Thank you.

@realModusOperandi
Copy link
Author

Thanks! I've made the PR: OpenLiberty/guide-rest-client-angular#1

@evelinec
Copy link
Contributor

Hi @realModusOperandi We went through the initial draft guide and provided some feedback in this issue OpenLiberty/guide-rest-client-angular#5. Would you take a look? Thank you.

@yeekangc yeekangc changed the title Angular 7 equivalent of "Consuming a RESTful web service with AngularJS"? Consuming a RESTful web service with Angular 7 Apr 29, 2019
@evelinec
Copy link
Contributor

evelinec commented May 8, 2019

Hi @realModusOperandi, sorry for the delay in responding to your questions on the previous issue. We'll get back to them as soon as we can. Meanwhile, we got some more review feedback from our team in this issue, OpenLiberty/guide-rest-client-angular#7. Let us know if you'd like take a look. Thank you.

@evelinec
Copy link
Contributor

Hi @realModusOperandi, I had gone through the guide with our peer review checklist and found a few more minor issues, as in OpenLiberty/guide-rest-client-angular#11. Let us know if you'd like to take a look.

Thank you.

@evelinec evelinec added peer reviewed the guide has been peer reviewed SME reviewed the guide has been reviewed by SME labels May 13, 2019
@evelinec
Copy link
Contributor

Hi @realModusOperandi, my team has reviewed the guide and provide some more feedback, in this issue, OpenLiberty/guide-rest-client-angular#13. Do you think you may take a look? Thank you.

@realModusOperandi
Copy link
Author

Lots to look at, I will address them today. Thanks!

@gkwan-ibm gkwan-ibm added the dev content reviewed the content of the guide has been reviewed by committer label May 29, 2019
@yeekangc yeekangc added the final content reviewed final content review before publishing label Jun 6, 2019
@evelinec
Copy link
Contributor

All remaining issues had been handled. @yeekangc you can sign off this guide now.

@evelinec evelinec added the user reviewed the guide has been reviewed by an end user label Jun 13, 2019
@evelinec
Copy link
Contributor

@Charlotte-Holt this guide is ready for you to review. Here's the repo: https://github.com/OpenLiberty/draft-guide-rest-client-angular

@evelinec
Copy link
Contributor

@justineechen to do end-to-end testing.

@yeekangc
Copy link
Member

yeekangc commented Jun 14, 2019

Do we have news on end-to-end testing? Will sign off after we have confirmation on that.

@evelinec
Copy link
Contributor

evelinec commented Jun 14, 2019

  • End-to-end test was completed
  • Addressed the one issue raised

@gkwan-ibm gkwan-ibm added the final end-to-end test completed the guide was verified from end to end label Jun 14, 2019
@yeekangc yeekangc added the signed off the guide can proceed to publishing label Jun 14, 2019
@evelinec
Copy link
Contributor

  • ID review is in progress

@yeekangc
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution dev content reviewed the content of the guide has been reviewed by committer final content reviewed final content review before publishing final end-to-end test completed the guide was verified from end to end ID reviewed new guide peer reviewed the guide has been peer reviewed signed off the guide can proceed to publishing SME reviewed the guide has been reviewed by SME target:ga user reviewed the guide has been reviewed by an end user
Projects
Development

No branches or pull requests

5 participants