FT: Last test review

[JunyiSun]

• "The following two steps set up the dynamic configuration on the system service and its client. You can move on to the next section, which adds the fallback mechanism on the inventory service."

You can move on to the next section??? Why you can move on to the next section?

• I think the following paragraphs can be simplified, they are too long and confusing, especially now you don't show the code on the website, it's hard to catch what you are talking about, you don't even need to talk about code here if you don't show the code. Just explain what scenario can happen without referring to code.

"First, the src/main/java/io/openliberty/guides/system/SystemResource.java class has the inMaintenance() condition, which determines that the system properties are returned only if you set the io_openliberty_guides_system_inMaintenance configuration property to false in the resources/CustomConfigSource.json file. Otherwise, the service returns a Status.SERVICE_UNAVAILABLE message, which makes it unavailable.

Next, the src/main/java/io/openliberty/guides/inventory/client/SystemClient.java class includes the getPropertiesHelper() method to make a request to the system service and check for the response. A condition is added in this method to stage the fault tolerance in the application. This condition checks if the response is specifically a Status.SERVICE_UNAVAILABLE message, which is a 503 status code. This code indicates that the server being called is unable to handle the request because of a temporary overload or scheduled maintenance, which would likely be alleviated after some delay. To simulate that the system is unavailable, an IOException is thrown.

The public getProperties() method in this class calls the getPropertiesHelper() method. The InventoryManager class calls this public method. You will look into the InventoryManager class in more detail in the next section."

• Overall, I think it's a good guide.

[evelinec]

This is the same issue raised in #46. Will move forward for now.

[yeekangc]

Agree with @evelinec. Should fix some of these sooner rather than later though especially for point 2.

[evelinec]

Fixed in #51