From 85872db76e29d4698139b805aa39357578a29775 Mon Sep 17 00:00:00 2001 From: Gilbert Kwan Date: Fri, 16 Dec 2022 10:04:47 -0500 Subject: [PATCH 1/2] Update test.yml --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 6e8a307..84f3b1c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -2,7 +2,7 @@ name: Test application on: pull_request: - branches: [ draft ] + branches: [ prod, staging ] jobs: check-files: @@ -27,7 +27,7 @@ jobs: env: VALIDATE_ALL_CODEBASE: false GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - DEFAULT_BRANCH: draft # todo remove after publishing + DEFAULT_BRANCH: prod LINTER_RULES_PATH: ./tools/pr-checker/linters/ VALIDATE_DOCKERFILE: true VALIDATE_JAVA: true From 975324747882ac78a29cf389ef31ccea2d0c9c15 Mon Sep 17 00:00:00 2001 From: Gilbert Kwan Date: Fri, 16 Dec 2022 07:07:24 -0800 Subject: [PATCH 2/2] Update README.adoc (#23) * Update README.adoc * Update test.yml --- README.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.adoc b/README.adoc index 198cad2..f039b30 100644 --- a/README.adoc +++ b/README.adoc @@ -34,13 +34,13 @@ Learn how to use Jakarta WebSocket to send and receive messages between services == What you'll learn -Jakarta WebSocket enables two-way communication between client and server endpoints. First, each client makes an HTTP connection to a Jakarta WebSocket server. The server can then broadcast messages to the clients. link:https://openliberty.io/guides/reactive-messaging-sse.html[Server-Sent Events (SSE)] also enables a client to receive automatic updates from a server via an HTTP connection however WebSocket differs from Server-Sent Events in that SSE is unidirectional from server to client, whereas WebSocket is bidirectional. WebSocket also enables real-time updates over a smaller bandwidth than SSE. The connection isn't closed meaning that the client can continue to send and receive messages with the server, without having to poll the server to receive any replies. +Jakarta WebSocket enables two-way communication between client and server endpoints. First, each client makes an HTTP connection to a Jakarta WebSocket server. The server can then broadcast messages to the clients. link:https://openliberty.io/guides/reactive-messaging-sse.html[Server-Sent Events (SSE)^] also enables a client to receive automatic updates from a server via an HTTP connection however WebSocket differs from Server-Sent Events in that SSE is unidirectional from server to client, whereas WebSocket is bidirectional. WebSocket also enables real-time updates over a smaller bandwidth than SSE. The connection isn't closed meaning that the client can continue to send and receive messages with the server, without having to poll the server to receive any replies. The application that you will build in this guide consists of the `client` service and the `system` server service. The following diagram depicts the application that is used in this guide. image::architecture.png[Application architecture where system and client services use the Jakarta Websocket API to connect and communicate. align="center"] -You'll learn how to use the link:https://openliberty.io/docs/latest/reference/javadoc/liberty-jakartaee9.1-javadoc.html?package=jakarta/websocket/package-frame.html&class=overview-summary.html[Jakarta WebSocket API] to build the `system` service and the scheduler in the `client` service. The scheduler pushes messages to the system service every 10 seconds, then the system service broadcasts the messages to any connected clients. You will also learn how to use a JavaScript `WebSocket` object in an HTML file to build a WebSocket connection, subscribe to different events, and display the broadcasting messages from the `system` service in a table. +You'll learn how to use the link:https://openliberty.io/docs/latest/reference/javadoc/liberty-jakartaee9.1-javadoc.html?package=jakarta/websocket/package-frame.html&class=overview-summary.html[Jakarta WebSocket API^] to build the `system` service and the scheduler in the `client` service. The scheduler pushes messages to the system service every 10 seconds, then the system service broadcasts the messages to any connected clients. You will also learn how to use a JavaScript `WebSocket` object in an HTML file to build a WebSocket connection, subscribe to different events, and display the broadcasting messages from the `system` service in a table. // ================================================================================================= // Getting started