LMP 3.9 devc mode -DdockerRunOpts does not work

[gkwan-ibm]

-DdockerRunOpts does not work

Scenario 1:

• used LMP 3.9 and Colima Docker on Mac
• run mvn liberty:devc -DdockerRunOpts="-e DB_HOSTNAME=172.17.0.2" -DserverStartTimeout=240
• run docker exec -it liberty-dev env | grep DB_HOSTNAME
• return nothing
  • expected same as Scenario 2

Scenario 2:

• used LMP 3.8.2 and Colima Docker on Mac
• run mvn liberty:devc -DdockerRunOpts="-e DB_HOSTNAME=172.17.0.2" -DserverStartTimeout=240
  • run 3 times for a known issue
• run docker exec -it liberty-dev env | grep DB_HOSTNAME
• return DB_HOSTNAME=172.17.0.2

[gkwan-ibm]

It blocked the new guide https://github.com/OpenLiberty/draft-guide-testcontainers.

[cherylking]

@gkwan-ibm Hi Gilbert, can you try containerRunOpts instead to make progress?

We replaced dockerRunOpts with containerRunOpts, but intended to preserve being able to specify dockerRunOpts. I think it works if you specify it in the pom.xml, but maybe not as a property from the command line. I can fix that in the next release so both work from the command line.

[gkwan-ibm]

-DcontainerRunOpts works, thanks

BTW, Rancher Desktop has the same issue.

[cherylking]

@gkwan-ibm I'm glad containerRunOpts works. By the way, our plugins have no awareness of whether you are using Colima or Rancher Desktop or whatever else. This is just a plugin configuration parameter that we modified to be more generic instead of Docker specific.

[scottkurz]

Noting that we didn't carry forward the "property" config in the past in the case of 'serverEnvFile' replacing 'serverEnv'.
So you can only do -DserverEnvFile not -DserverEnv now.

Not saying we are completely bound by that decision. If we want to support both properties we have to flag as an error or define our own precedence between them since I'm not sure how to have Maven do that for us. I think an error would be OK.