Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to disclose binary scanner license #1552

Open
6 of 9 tasks
TrevCraw opened this issue Jun 16, 2022 · 4 comments
Open
6 of 9 tasks

Update documentation to disclose binary scanner license #1552

TrevCraw opened this issue Jun 16, 2022 · 4 comments
Assignees
Labels
devMode generateFeatures Issues that target the generateFeatures branch medium priority

Comments

@TrevCraw
Copy link
Contributor

TrevCraw commented Jun 16, 2022

Disclose dependency on IBM WebSphere Application Server Migration Toolkit for Application Binaries which is separately licensed under ILAN. Share link to the public ILAN license: https://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/wasdev/license/wamt/en.html

Update the following doc pages:

Add binary scanner as "runtime dependency" on Maven Central for the build plugins:

@TrevCraw TrevCraw added devMode generateFeatures Issues that target the generateFeatures branch labels Jun 16, 2022
@DoloresLopez
Copy link

Hello @TrevCraw can this issue be closed? If not, what else is needed

@TrevCraw TrevCraw self-assigned this Sep 19, 2022
@cherylking
Copy link
Member

@TrevCraw For this part:

Add binary scanner as "runtime dependency" on Maven Central for the build plugins:

I think it means adding a runtime dependency in the pom.xml/build.gradle so that it is documented that it is a dependency, even though it is not needed for compilation. We would need to make sure that it does not get bundled in the plugin jar though.

@TrevCraw
Copy link
Contributor Author

The following doc pages have been updated:

LMP README: https://github.com/OpenLiberty/ci.maven
Dev mode (Maven): https://github.com/OpenLiberty/ci.maven/blob/main/docs/dev.md
Generate features (Maven): https://github.com/OpenLiberty/ci.maven/blob/main/docs/generate-features.md
LGP README: https://github.com/OpenLiberty/ci.gradle
Dev mode (Gradle): https://github.com/OpenLiberty/ci.gradle/blob/main/docs/libertyDev.md
Generate features (Gradle): https://github.com/OpenLiberty/ci.gradle/blob/main/docs/generateFeatures.md

An issue has been opened to address updating the Open Liberty docs dev mode page: OpenLiberty/docs#5828

Figuring out how to add binary scanner as a dependency on Maven Central will be addressed at a later date.

@cherylking
Copy link
Member

Just wanted to note here that I tried adding the dependency as a runtime dependency in the pom.xml and it caused the binary scanner to get downloaded every single time any goal was run on the Liberty Maven Plugin. That is not desirable or acceptable. I also tried adding the <optional>true</optional> config to the runtime dependency and it had no affect. We could consider listing it as a provided dependency but that is a bit misleading.

Whatever we decide to do, it needs to not have a detrimental affect to the performance of the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devMode generateFeatures Issues that target the generateFeatures branch medium priority
Projects
Development

No branches or pull requests

3 participants