Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] npm run script for testing missed from published package #63

Open
DerekNonGeneric opened this issue Jul 21, 2022 · 0 comments
Open

Comments

@DerekNonGeneric
Copy link
Member

This package is currently being flagged by Socket with a Severity: Medium issue due to a lack of tests. This is negatively impacting how its quality score is performing over there. To avoid getting flagged for this by Socket, the test property of the scripts object in the package.json file of our next releases need to contain the testing command for it to run. It seems to have been omitted even though we do actually have some tests (coverage is far from complete). The lack of coverage metrics is another story entirely.

It would be a good idea if we could include a check to ensure that our packages are published with this property specifying a shell command to run for testing. It may be worth noting that a non-zero exit code would equate to test failure according to CITGM, npmlog, and elsewhere, which is something to consider when determining the command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant