TurbSim: User-defined time series updates #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating simulated data from a user-defined time-series input file, there was a mismatch between calculating the number of points in the time-series FFT and the inverse FFT if either of those values were originally entered as not a product of small primes. Time was subtracted from the user input time series, but added to the `AnalysisTime`, possibly causing an error to be triggered. Now both subtract when user-defined time series are used. Best practice is still to enter the time history and analysis time as products of small primes. The code is unchanged when user-defined time series are NOT used. Also, a possible array overflow issue was corrected when the user entered time series that were not a product of small primes.
jjonkman
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
When generating simulated data from a user-defined time-series input file, there was a mismatch between calculating the number of points in the time-series FFT and in the inverse FFT if either of those values were originally entered as not a product of small primes. Time was subtracted from the user input time series, but added to the
AnalysisTime, possibly causing an error to be triggered. Now both subtract when user-defined time series are used. The code is unchanged when user-defined time series are NOT used.Also, a possible array overflow issue was corrected when the user entered time series that were not a product of small primes.
Best practice is still to enter the time history and analysis time to give the number of steps as a products of small primes, in which case these modifications won't do anything.
Related issue, if one exists
None
Impacted areas of the software
TurbSim with user-defined time series (TurbModel = "TIMESR")
Test results, if applicable
This should not change any test results.