Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate Limiting #266

Closed
2 tasks
NoraCodes opened this issue Jan 26, 2018 · 2 comments · Fixed by #676
Closed
2 tasks

Rate Limiting #266

NoraCodes opened this issue Jan 26, 2018 · 2 comments · Fixed by #676
Assignees
@truongdd03
Labels
f-admin-panel This issue is related to the admin panel functionality. p-medium-priority t-enhancement This issues tracks a potential improvement to the software
Milestone
0.8 release

Comments

@NoraCodes
Copy link
Contributor

The API executes a great deal of code on the server, and could easily be leveraged to cause a DoS condition. We should add:

  • a configurable limit to API access rate, possibly
  • bypassable with a token available from the admin panel
@NoraCodes NoraCodes added t-enhancement This issues tracks a potential improvement to the software p-medium-priority f-admin-panel This issue is related to the admin panel functionality. labels Jan 26, 2018
@NoraCodes NoraCodes added this to the 1.0 Release milestone Jan 26, 2018
@johndiiorio
Copy link
Contributor

Recommend using express-rate-limit for this purpose.

@huss huss mentioned this issue Apr 25, 2021
Merged
5 tasks
@huss
Copy link
Member

huss commented May 17, 2021

PR #633 also has a rate limiting warning from CodeQL that should be fixed.

@truongdd03 truongdd03 mentioned this issue Nov 27, 2021
Merged
5 tasks
@huss huss modified the milestones: 1.0 Release, 0.8 release Dec 5, 2021
@huss huss closed this as completed in #676 Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@truongdd03 truongdd03

Labels
f-admin-panel This issue is related to the admin panel functionality. p-medium-priority t-enhancement This issues tracks a potential improvement to the software
Projects
None yet
Milestone
0.8 release
Development

Successfully merging a pull request may close this issue.

Add access rate limit truongdd03/OED
4 participants
@huss @NoraCodes @johndiiorio @truongdd03