This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Reapply "Minor cleanups" #1434
Merged
Reapply "Minor cleanups" #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi there folks, got a bit lost with this huge PR of mine. If I understand correctly it was merged, but then removed due to issues with some other IPFS merge. Let me know if you want me to try and rebase again and solve conflicts with IPFS stuff. I was just shooting to reduce the huge number of warnings I was getting, as warnings usually lead to a bunch of sketchy issues, and also I was getting familiar with the codebase to see if I could be of more substantial help in my free time. |
|
Merge conflicts :/ |
cpacia
force-pushed
the
revert-1433-revert-1306-minor-cleanups
branch
from
b10a05e
to
f662c7a
Compare
cpacia
force-pushed
the
revert-1433-revert-1306-minor-cleanups
branch
from
26170ab
to
0840109
Compare
|
Cheers and thanks for that big merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1433 which reapplies #1306. This will be held until after #1425 is completed.