This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Minor cleanups #1306
Merged
Minor cleanups #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks @gubatron ! |
|
I think I need some help getting the travis-ci build to pass. The travis build fails saying that 3 files are not goimports-ed. I've tried
When I run |
|
This should be ready for revision. |
|
Thanks for being patient @gubatron. I'll do my best to get this reviewed in the next day or so. Really appreciate the contribution. |
|
Thanks for letting me know it hasn't been forgotten! I understand how it is. |
cpacia
approved these changes
Jan 8, 2019
|
This looks good to merge after release |
(where Pb stands for ProtoBuffer)
Did not use 'peerID' as it's already being used as a parameter to the function
pb not redundant as package is actually called namesys.pb
pb not redundant as package is actually called namesys.pb compilation works once again
Should save memory in the event the slice isn't used right away
…tion Fixed a few typos along the way too
|
rebased once again, cheers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a few low hanging fruit I could find, broken down into individual commits in case you don't want to merge all and you want to cherry pick some.
Fixed:
Cheers.
Some Go/Jetbrains GoLand help needed
PS: Is anybody using Jetbrains Goland IDE?
if so, are you having issues with the vendor folder excluding all the
gx/ipfs/<IP_HASH>/packageimports? I noticed that thevendorfolder has all those packages there, but the IDE is having issues finding them even though I have them. Played with GOPATH in the project to no success.the folders are there though, not sure why it'd be able to find all the other vendor packages and not the gx/ipfs ones
Once I get that to work I'll be able to find lots of things to cleanup, unused variables, parameters, and more.
EDIT: Found cause to my dependencies issue. I had manually
git cloned the project instead of working on the folder automatically cloned bygoinsideGOPATH/src/OpenBazaar/openbazaar-go.I've submitted another PR with some documentation notes for linux/mac users new to golang like myself.