-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:4.0spop #2998
fix:4.0spop #2998
Conversation
WalkthroughThe changes in the Changes
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
src/storage/src/redis_sets.cc (3)
920-920
: Consider using a member variable for the random engine.Creating a new random engine for each call is inefficient. Consider making it a member variable of the Redis class to avoid reinitialization overhead.
- std::default_random_engine engine(std::random_device{}());
Add to the Redis class header:
private: std::default_random_engine random_engine_{std::random_device{}()};
947-957
: Consider using WriteBatch::Delete for bulk operations.When deleting all members, consider using a single WriteBatch::Delete operation for better performance.
- for (iter->Seek(sets_member_key.EncodeSeekKey()); - iter->Valid(); - iter->Next()) { - batch.Delete(handles_[kSetsDataCF], iter->key()); - ParsedSetsMemberKey parsed_sets_member_key(iter->key()); - members->push_back(parsed_sets_member_key.member().ToString()); - } + std::string start_key = sets_member_key.EncodeSeekKey().ToString(); + std::string end_key = start_key; + end_key.back()++; // Increment last byte to get range end + batch.DeleteRange(handles_[kSetsDataCF], start_key, end_key); + + // Still need to iterate to collect members + for (iter->Seek(start_key); iter->Valid() && iter->key() < end_key; iter->Next()) { + ParsedSetsMemberKey parsed_sets_member_key(iter->key()); + members->push_back(parsed_sets_member_key.member().ToString()); + }
Line range hint
990-997
: Consider adding transaction support.The meta value update and member deletions should be atomic. While WriteBatch provides some atomicity, consider adding explicit transaction support for stronger consistency guarantees.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/storage/src/redis_sets.cc
(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: build_on_ubuntu
- GitHub Check: build_on_centos
- GitHub Check: build_on_macos
- GitHub Check: Analyze (go)
🔇 Additional comments (3)
src/storage/src/redis_sets.cc (3)
916-919
: Good addition of input validation!The validation check for the
cnt
parameter is a good defensive programming practice.
966-972
: Good use of modern C++ algorithms!The use of
std::iota
,std::shuffle
, andstd::sort
is a clean and efficient way to handle random selection.
974-986
: Consider adding error handling for iterator validity.The code assumes the iterator will be valid for all target indices. Add error handling for cases where the iterator becomes invalid before reaching all targets.
for (iter->Seek(sets_member_key.EncodeSeekKey()); iter->Valid() && target_iter != indices.end(); iter->Next(), ++cur_index) { + if (!iter->Valid()) { + delete iter; + return Status::Corruption("Iterator invalidated during member deletion"); + } if (cur_index == *target_iter) { batch.Delete(handles_[kSetsDataCF], iter->key()); ParsedSetsMemberKey parsed_sets_member_key(iter->key()); members->push_back(parsed_sets_member_key.member().ToString()); ++del_count; ++target_iter; } } + if (target_iter != indices.end()) { + delete iter; + return Status::Corruption("Failed to process all target indices"); + }
Summary by CodeRabbit
Bug Fixes
Performance