Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: output result is not the same as Redis 'hello' command #2190

Closed
AlexStocks opened this issue Dec 7, 2023 · 5 comments
Closed

bug: output result is not the same as Redis 'hello' command #2190

AlexStocks opened this issue Dec 7, 2023 · 5 comments
Labels
3.5.3 bug ☢️ Bug Something isn't working

Comments

@AlexStocks
Copy link
Contributor

AlexStocks commented Dec 7, 2023

Is this a regression?

Yes

Description

bug:
1 there should be number param for hello command
2 the connection should not be cancelled in command 'hello 2'

redis ’hello' command doc https://redis.io/commands/hello/

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

Redis Test Results:

image

“正确” 的 Redis 行为是:只支持 “hello 2" & "hello 3"

Pika Test Results:
image

Pika 支持了 "hello" & "hello 3",对 “hello 2” 反而不支持,而且 “hello 3” 结果与 “hello 2" 有异。

Please provide the version you discovered this bug in (check about page for version information)

No response

Anything else?

No response

@AlexStocks AlexStocks added ☢️ Bug Something isn't working bug 3.5.3 labels Dec 7, 2023
@weedge
Copy link
Contributor

weedge commented Dec 8, 2023

.... 3.4.1+开始已经支持hello哈;奇怪, 本来想看下 hello命令看能否修下, bug 咋复现不出来呢?笔记地址: https://colab.research.google.com/drive/1VQLSV8icUvbpjEe9jvU9VTBoXyikEotL [捂脸]

@AlexStocks
Copy link
Contributor Author

.... 3.4.1 + 开始已经支持 hello 哈;奇怪,本来想看下 hello 命令看能否修下, bug 咋复现不出来呢?笔记地址: https://colab.research.google.com/drive/1VQLSV8icUvbpjEe9jvU9VTBoXyikEotL [捂脸]

please download the latest unstable branch codes and then test it.

@AlexStocks
Copy link
Contributor Author

@Mixficsol 负责验证

@Mixficsol
Copy link
Collaborator

@Mixficsol 负责验证
已经验证完毕,hello2 和 hello3目前返回数据一致,且hello2不会造成core dump

@AlexStocks
Copy link
Contributor Author

hello 测试 redis 7.2 结果如下:

image

在 最新 pika(3.5.3) 中,大体已经与 redis 7.2 保持一致,但是 'hello 2' 与 'hello 3' 响应一样,原因是 pika 尚未支持 RESP 3。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.5.3 bug ☢️ Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants