sdist not being uploaded along with the wheels.

[WilliamJamieson]

This is related to astropy/astropy#15597.

Background

The astropy 6.0rc1 release was triggered, which triggered the building and uploading of the astropy 6.0rc1 wheels to PyPi, see https://github.com/astropy/astropy/actions/runs/6817064464/job/18540287448. The issue is that the source distribution was not uploaded to PyPi along side all the pre-built wheels.

It looks like the Run actions/upload-artifact@v3 step was successfully triggered by all of the wheel builds, see for example https://github.com/astropy/astropy/actions/runs/6817064464/job/18539760549. However, for the source distribution Run actions/upload-artifact@v3 was not triggered, see https://github.com/astropy/astropy/actions/runs/6817064464/job/18539753723.

As far as I can tell, the source distribution upload would only be blocked by:

github-actions-workflows/.github/workflows/publish.yml

Lines 235 to 236 in 59a929b

	if: |
	needs.targets.outputs.upload_to_pypi == 'true' || inputs.upload_to_anaconda

This appears to be identical to the wheel upload blocker:

github-actions-workflows/.github/workflows/publish.yml

Lines 193 to 194 in 59a929b

	if: |
	needs.targets.outputs.upload_to_pypi == 'true' || inputs.upload_to_anaconda

Yet the former was blocked while the latter was not. Diving into the logs we see that for both the source and wheel builds the inputs both clearly have upload_to_pypi: true meaning that in both cases the upload should have occurred, see

• Source: https://github.com/astropy/astropy/actions/runs/6817064464/job/18539753723#step:1:84
• Wheel: https://github.com/astropy/astropy/actions/runs/6817064464/job/18539760549#step:1:84

So I do not understand why one uploads while the other does not. There are no failures in any of the steps proceeding the failure.

[WilliamJamieson]

Tagging @ConorMacBride and @Cadair for assistance.

[astrofrog]

I've been investigating this but I also don't understand what is going on. Will keep trying, but in the meantime I think it should be safe to upload a locally built sdist.

[WilliamJamieson]

The stcal package experienced the same issue (source distribution did not get uploaded to PyPi) today when it made a release. See the log: https://github.com/spacetelescope/stcal/actions/runs/6881432549/job/18717759512

[astrofrog]

Ok I'll try and investigate some more

[astrofrog]

Mystery solved: #169

[astrofrog]

@WilliamJamieson - I've tagged a new release of the workflows so things should work properly next time. Let me know if not!

[WilliamJamieson]

I can confirm that this indeed fixed the issue. stcal successfully uploaded everything via the run of: https://github.com/spacetelescope/stcal/actions/runs/6892869688/job/18751126499
see: https://pypi.org/project/stcal/1.5.1/#files for PyPi confirmation.