Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Support git repositories other than github.com #3755

Closed
qmuntal opened this issue Aug 26, 2019 · 3 comments
Closed

[REQ] Support git repositories other than github.com #3755

qmuntal opened this issue Aug 26, 2019 · 3 comments

Comments

@qmuntal
Copy link
Contributor

qmuntal commented Aug 26, 2019

I'm hosting an auto generated go client in an private instance of github enterprise and the generated mod.go file points to github.com instead of my own host.

I would like to be able to configure the host of my git repository using a cli parameter, for example --git-host, in the same way as it is done for --git-user-id and --git-repo-id.

Without this parameter, the only alternatives I have are:

  • Manually update the auto generated code, which creates a maintenance problem when regenerating the code.
  • Create an custom extension with the hard-coded host, which seem to be an overkill to just modify an url
@wing328
Copy link
Member

wing328 commented Aug 26, 2019

That sounds reasonable. Would you have time to contribute the enhancement?

@qmuntal
Copy link
Contributor Author

qmuntal commented Aug 26, 2019

Yes I do.
@wing328 do you know if this parameter could be used in more places other than git_push.sh and go.mod? My initial focus will be this two files.

@wing328
Copy link
Member

wing328 commented Aug 26, 2019

We can start with these 2 files first.

Later we can roll it out to other files like PHP composer config file, Ruby client's README, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants