Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cmath for Math on both Windows and Linux #51

Closed
wants to merge 2 commits into from
Closed

Use cmath for Math on both Windows and Linux #51

wants to merge 2 commits into from

Conversation

IndrajeetPatil
Copy link
Member

Closes #50

msevestre
msevestre requested changes Apr 1, 2022
View reviewed changes
Copy link
Member

@msevestre msevestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@IndrajeetPatil IndrajeetPatil marked this pull request as draft April 1, 2022 18:20
@IndrajeetPatil
Copy link
Member Author

I will mark this "Ready for review" when I manage to add tests. Need to figure how to do it first 😅

@IndrajeetPatil
Copy link
Member Author

I thought this covered the code in question, but probably not:

OSPSuite.FuncParser/tests/TestFuncParserCPP/TestFuncParser.cpp

Lines 60 to 70 in 532b6d8

if(Math::IsFinite(dValue))
std::cout<<dValue<<std::endl;
else
{
if(Math::IsNaN(dValue))
std::cout<<"NaN"<<std::endl;
else if(Math::IsInf(dValue))
std::cout<<"Inf"<<std::endl;
else if(Math::IsNegInf(dValue))
std::cout<<"-Inf"<<std::endl;
}

@Yuri05
Copy link
Member

Yuri05 commented Apr 2, 2022

I thought this covered the code in question, but probably not:

No, this is just a small command line app for interactive tests and e.g. for memory/performance profilers etc.
It is neither compiled nor executed on AppVeyor.

As @msevestre said (s. #50 (comment)) all tests are part of OSPSuite.FuncParser.Tests project, which is included into the "main solution OSPSuite.FuncParser.sln
If you open the solution in Visual Studio, you can run all the tests either via Resharper or via VS built-in test runner

@IndrajeetPatil
Copy link
Member Author

Closing this as I won't be able to add any tests.

@IndrajeetPatil IndrajeetPatil deleted the 50_consolidate_implementations branch July 28, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msevestre msevestre msevestre requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use <cmath> for Windows and Linux
3 participants
@IndrajeetPatil @Yuri05 @msevestre