Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggested improvement to normalize on base #8

Closed
tensorfoo opened this issue Jul 13, 2021 · 1 comment
Closed

suggested improvement to normalize on base #8

tensorfoo opened this issue Jul 13, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@tensorfoo
Copy link

tensorfoo commented Jul 13, 2021

Hi great work so far. Just one thing, i've noticed that even though the original wav2vec2 base model did not have normalization (but did have it enabled for large), the author has suggested future models even small ones to use normalization.

So i would suggest if a future training run for CLSRIL-23 be done with normalization as suggested. I tried using CLSRIL-23 as a base for pretraining and it seems to work fine with normalization=True but if you also add in model.extractor_mode='layer_norm' as suggested I got an error.

@harveenchadha
Copy link
Collaborator

Hi,

Thanks for the good suggestion. We will try to do it with norm enabled, but can't commit on this.

@harveenchadha harveenchadha added the enhancement New feature or request label Aug 4, 2021
@harveenchadha harveenchadha pinned this issue May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants