Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI test runs on stable #2199

Closed
matrss opened this issue Feb 14, 2024 · 1 comment · Fixed by #2205
Closed

Fix CI test runs on stable #2199

matrss opened this issue Feb 14, 2024 · 1 comment · Fixed by #2205
Assignees
Labels
bug Something isn't working tests
Milestone

Comments

@matrss
Copy link
Collaborator

matrss commented Feb 14, 2024

The CI test runs on stable fail consistently right now. Looking through the list of installed packages I saw that pyvirtualdisplay is now missing in the list for the recent runs of the tests. This might be the reason for the failures.

@matrss
Copy link
Collaborator Author

matrss commented Feb 14, 2024

I guess the issue is that the installation of pyvirtualdisplay was removed from the Dockerfile that builds the image for stable, but stable still needs it (develop doesn't). It was removed here: Open-MSS/dockertesting@753d79a#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L42

The workflow should probably install it into the environment until it is no longer necessary, or just use xvfb-run like on develop.

@matrss matrss added the bug Something isn't working label Feb 15, 2024
@matrss matrss added this to the 8.3.4 milestone Feb 15, 2024
@matrss matrss self-assigned this Feb 15, 2024
@matrss matrss linked a pull request Feb 15, 2024 that will close this issue
@matrss matrss closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants