Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregate_temporal_period missing some predefined periods #27

Open
clausmichele opened this issue Dec 21, 2022 · 1 comment
Open

aggregate_temporal_period missing some predefined periods #27

clausmichele opened this issue Dec 21, 2022 · 1 comment

Comments

@clausmichele
Copy link
Member

The current implementation is missing some temporal periods which are not yet defined, since they are not pandas standard.
Additionally, if an openEO period is being selected and it's not present in the python code, there's no warning and it will raise an Exception due to the frequency variable missing.

Some good examples for Pandas periods:
https://regenerativetoday.com/a-complete-guide-to-time-series-analysis-in-pandas/

openEO process definition:
https://processes.openeo.org/#aggregate_temporal_period

Missing openEO periods:

    dekad: Ten day periods, counted per year with three periods per month (day 1 - 10, 11 - 20 and 21 - end of month). The third dekad of the month can range from 8 to 11 days. For example, the fourth dekad is Feb, 1 - Feb, 10 each year.
    tropical-season: Six month periods of the tropical seasons (November - April, May - October).
    decade: Ten year periods ([0-to-9 decade](https://en.wikipedia.org/wiki/Decade#0-to-9_decade)), from a year ending in a 0 to the next year ending in a 9.
    decade-ad: Ten year periods ([1-to-0 decade](https://en.wikipedia.org/wiki/Decade#1-to-0_decade)) better aligned with the anno Domini (AD) calendar era, from a year ending in a 1 to the next year ending in a 0.

an idea could be to just define custom periods based on the inputs and re use aggregate_temporal.

@LukeWeidenwalker
Copy link
Contributor

Agreed, this is an implementation gap from before that's never been addressed for lack of bandwidth - using pandas custom periods like you suggest sounds like a good idea to me! Would definitely be good to support all the predefined options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants