Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support generic reducers in aggregate_spatial (aka zonal_statistics) #49

Closed
soxofaan opened this issue Nov 12, 2020 · 4 comments
Closed

Comments

@soxofaan
Copy link
Member

aggregate_spatial/zonal_statistics in openeo-geopyspark-driver (and openeo-python-driver) assumes the provided reducer is a simple one-process reducer, and only supports: 'histogram', 'sd', 'median' or 'mean'

(also: I think it would be cleaner if we could also remove the usage of old-style "zonal_statistics" and use 1.0-style "aggregate_spatial" in more places)

@soxofaan
Copy link
Member Author

also see Open-EO/openeo-python-client#144

@jdries
Copy link
Contributor

jdries commented Sep 21, 2021

Note that this is far from trivial, the current code path is based on computing histograms, and can only support statistics based on that.
It would be nice to have a use case or example of what would be useful to additionally support.

@soxofaan
Copy link
Member Author

soxofaan commented Sep 21, 2021

Indeed, generic aggregate_spatial reducers will be lot of work with probably not a lot of uptake at the moment.

However there are still some simple one-process reducers we could easily add (based on histograms),
e.g. from the "reducer" category listing at https://processes.openeo.org/:

  • max and min
  • count basic version: count valid elements (condition=null), or count all elements (condition=true)
  • quantiles (but there is an additional array_element necessary to extract a scalar value from the quantiles array)

@jdries
Copy link
Contributor

jdries commented Feb 25, 2022

this one got fixed, we now also support using multiple reducers.
Fully generic is harder, so we focus on the list marked as 'reducer' in openeo-processes.

@jdries jdries closed this as completed Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants