Guarantee that messageView is a subview of OSInAppMessageViewController #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is swiftUI crash where addConstraintsForMessage can be called without messageView being a subview of OSInAppMessageViewController's view. This is likely happening because viewWillTransitionToSize is being called before setupInitialMessageUI. Neither the crash reporters nor OneSignal have been able to reproduce the crash, but it is safe to always add messageView as a subview if it is not already.
jkasten2
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Jeasmine and @nan-li)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is swiftUI crash where
addConstraintsForMessagecan be called withoutmessageViewbeing a subview of OSInAppMessageViewController's view. This is likely happening becauseviewWillTransitionToSizeis being called beforesetupInitialMessageUI. Neither the crash reporters nor OneSignal have been able to reproduce the crash, but it is safe to always addmessageViewas a subview if it is not already.Fixes #819
This change is