Fixing webviews not being cleared properly #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emawby
force-pushed
the
fix/second_webview_not_cleared
branch
from
9b48ad9
to
ce02055
Compare
emawby
changed the title
Jeasmine
reviewed
Aug 5, 2020
| } | ||
| navController.presentationController.delegate = self; |
There was a problem hiding this comment.
can you add a comment to explain this? for the future 😬
There was a problem hiding this comment.
This looks like a standard delegate setup, I am ok without having a comment in code
https://developer.apple.com/documentation/uikit/uipresentationcontroller/1618329-delegate
| if (!viewControllerForPresentation.view.superview) | ||
| [mainWindow addSubview:[viewControllerForPresentation view]]; | ||
| if (!viewControllerForPresentation.view.superview) { | ||
| [mainWindow addSubview:[viewControllerForPresentation view]]; |
There was a problem hiding this comment.
ah yes, there is an extra space here
jkasten2
approved these changes
Aug 6, 2020
| } | ||
| navController.presentationController.delegate = self; |
There was a problem hiding this comment.
This looks like a standard delegate setup, I am ok without having a comment in code
https://developer.apple.com/documentation/uikit/uipresentationcontroller/1618329-delegate
| if (!viewControllerForPresentation.view.superview) | ||
| [mainWindow addSubview:[viewControllerForPresentation view]]; | ||
| if (!viewControllerForPresentation.view.superview) { | ||
| [mainWindow addSubview:[viewControllerForPresentation view]]; |
There was a problem hiding this comment.
ah yes, there is an extra space here
emawby
force-pushed
the
fix/second_webview_not_cleared
branch
from
ce02055
to
ccd0251
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webviews were not being cleared properly if multiple were queued in a row. #606
In
OneSignalWebView'sshowInAppmethod we were attempting to reusenavControllerandviewControllerForPresentationwhen opening webviews in the App. However thepresentationController delegatelifecycle methods were not being properly called for the second webivew after removing theviewControllerForPresentation.viewfrom its superview.This was because upon clearing the
navControllerits presentationController delegate would get reset, and we only set the delegate if thenavControllerwas nil. The fix is to always set thenavController.presentationController.delegate = selfThis change is