Added jsonRepresentation method to OSInAppMessageAction class
#704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `OSJSONEncodable` now opens up possibility to have the `jsonRepresentation` method * Modified how we construct the json for the `OSInAppMessageAction` class * Fixed demo app example IAM click block and now print out the constructed json rep
Jeasmine
approved these changes
Jun 29, 2020
* Fixed comment format to `//` instead of `/* */` * Changed how jsonRepresentation method internals work * Added `null` check for `clickUrl` because we have to call `absoluteString` method `NSURL` class
* `OSInAppMessageTag` now has `jsonRepresentation` * Made `tagsToAdd` and `tagsToRemove` public access * `OSInAppMessageOutcome` now has `jsonRepresentation` * Made `name`, `weight`, and `unique` public access * Wihtin `OSInAppMessageAction` now, the `tags` and `outcomes` are also public access * This is now consistently with Android IAM click action class and what is given to the developers from the IAM click handler
jkasten2
approved these changes
Jun 30, 2020
mikechoch
deleted the
fix/in_app_message_click_json_rep_method_and_format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSJSONEncodablenow opens up possibility to have thejsonRepresentationmethodOSInAppMessageActionclassMajor difference noticed between Android click event and iOS... Below is a screenshot showing the Android payload when tags or outcomes are included in the click action
Now iOS payload example witch shows consistency between both SDKs
Example 1:
Example 2:
Example 3:
This change is