[5.0.0] Fix direct session influence #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This was a remaining TODO * Moved where `appEntryState` lives away from `OneSignal` to the `OneSignalOutcomes` module, and lives on `OSSessionManager` * Also server expects session_time as an int, not float
* We truncate session time to an int and it may become 0 seconds, but we will receive an error response from the server if we send 0 seconds of session_time
* Removed `weak` reference to delegate as it was immediately null after being set in startup code * Therefore, all calls to the delegate were falling through the guard statement
nan-li
force-pushed
the
5.0.0/fix_session_influence
branch
from
f123761
to
cd47dda
Compare
* Rename `OSBackgroundTaskManagerDelegate` -> `OSBackgroundTaskHandler` because it is not truly a delegate, but is a concrete implementation that is injected
nan-li
changed the title
emawby
approved these changes
Aug 10, 2023
This was referenced Aug 10, 2023
Merged
nan-li
added a commit
that referenced
this pull request
Oct 30, 2023
[5.0.0] Fix direct session influence
nan-li
added a commit
that referenced
this pull request
Oct 30, 2023
[5.0.0] Fix direct session influence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix direct session influence to detect that we opened a notification and will send the influences to the outcomes endpoint.
Details
Motivation
We needed to track a session is started from a notification click for influences and outcomes.
Scope
Fix session logic from a notification clicked
appEntryStatelives away fromOneSignalto theOneSignalOutcomesmodulesession_timeas an int >= 1, not floatFix Background Task Manager
weakreference to delegate as it was immediately null after being set in startup codeOSBackgroundTaskManagerDelegate->OSBackgroundTaskHandlerbecause it is not truly a delegate, but is a concrete implementation that is injectedOther
A followup PR is made to refactor background tasks further
Testing
Unit testing
No
Manual testing
iPhone 13 pro 16.6 iOS version
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is