Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User model modularize Location and InAppMessages #1273

Merged
merged 25 commits into from
Jul 17, 2023
Merged

User model modularize Location and InAppMessages #1273

merged 25 commits into from
Jul 17, 2023

Commits on Jun 20, 2023

  1. Create blank OneSignalLocation framework

    @emawby
    emawby committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    aab3b38 View commit details
    Browse the repository at this point in the history

  2. Move Location files to OneSignalLocation framework 

    Note that LocationRequests are no longer needed as the location is sent as a User property. They are only referenced from unit tests and can be cleaned up.
    @emawby
    emawby committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    81784af View commit details
    Browse the repository at this point in the history

  3. Updating OneSignalLocation imports

    @emawby
    emawby committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    1d024f0 View commit details
    Browse the repository at this point in the history

  4. Use OneSignalLocation framework in dev app

    @emawby
    emawby committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    5796ca2 View commit details
    Browse the repository at this point in the history

  5. Create blank OneSignalInAppMessages framework

    @emawby
    emawby committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c4aeb93 View commit details
    Browse the repository at this point in the history

  6. Move In App Messages files to OneSignalInAppMessages framework

    @emawby
    emawby committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    10dddc4 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Updating OneSignalInAppMessages imports

    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    e2053bc View commit details
    Browse the repository at this point in the history

  2. Moving code out of OneSignalFramework for IAM module dependencies 

    OneSignalInAppMessages now builds.
Removed dependencies on code in OneSignalHelper and OneSignalViewHelper.
Moved SessionTime to OSSessionManager
    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9fd635e View commit details
    Browse the repository at this point in the history

  3. Updating OneSignalFramework to use OneSignalInAppMessages framework

    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    aed7c9a View commit details
    Browse the repository at this point in the history

  4. Build OneSignalFramework without dependency on location and IAM 

    The public protocols for OSInAppMessages and OSLocation have been moved to OneSignalCore along with a stub implementation.
This is a PoC implementation using ClassFromString but we could use injection instead to get the concrete implementation of OneSignalLocation and OneSignalInAppMessages without using classfromstring
    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    73fee6f View commit details
    Browse the repository at this point in the history

  5. Adding a helper method for NSInvocation to OneSignalCoreHelper and us… 

    …ing it for location
    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4dba9dc View commit details
    Browse the repository at this point in the history

  6. Forward onApplicationDidBecomeActive to MessagingController through O… 

    …neSignalInAppMessages
    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    a708527 View commit details
    Browse the repository at this point in the history

  7. Migrate IAMs in the IAM framework 

    The Migration controller will now tell the OneSignalInAppMessages framework to do its migration. This way the MigrationController doesn't need to reference internal IAM classes.
    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9460834 View commit details
    Browse the repository at this point in the history

  8. Add OneSignalInAppMessages to the dev app

    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    781fff9 View commit details
    Browse the repository at this point in the history

  9. Rename OneSignalLocation classes -> OneSignalLocationManager

    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c20a28c View commit details
    Browse the repository at this point in the history

  10. Updated podspec and build script for new modules

    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d128864 View commit details
    Browse the repository at this point in the history

  11. test modularized binaries

    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9a4d7d8 View commit details
    Browse the repository at this point in the history

  12. mark OSCore as extension safe

    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    761f70d View commit details
    Browse the repository at this point in the history

  13. Fixing IAM location prompting

    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    dd8bffc View commit details
    Browse the repository at this point in the history

  14. new test binaries after fixes

    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    eeb1758 View commit details
    Browse the repository at this point in the history

  15. Adding Location and InAppMessages SwiftPM products

    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    a162f49 View commit details
    Browse the repository at this point in the history

  16. add location and IAMs to update_swift_package.sh

    @emawby
    emawby committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    441e361 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Fixing copyright

    @emawby
    emawby committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    62af317 View commit details
    Browse the repository at this point in the history

  2. Removing launchURLsInApp and webkit code from Notifications 

    We are removing the launch push notification urls in a webview feature. This feature was not consistently effective, and added a webkit dependency to notifications that has gotten apps rejected from the app store. If we later want to add this feature back we should consider it as an optional module.
    @emawby
    emawby committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    8350017 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1275 from OneSignal/user_model/remove_launch_urls… 

    …_in_app

[User model] Remove launch urls in app
    @emawby
    emawby committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    0dc4f15 View commit details
    Browse the repository at this point in the history