-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0.0] Push Subscription Observer - API update #1260
Merged
emawby
merged 7 commits into
5.0.0/notification_foreground_listener_api
from
5.0.0/push_subscription_observer_api
May 1, 2023
Merged
[5.0.0] Push Subscription Observer - API update #1260
emawby
merged 7 commits into
5.0.0/notification_foreground_listener_api
from
5.0.0/push_subscription_observer_api
May 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename OSPushSubscriptionStateChanges to OSPushSubscriptionChangedState * Rename event from onOSPushSubscriptionChanged to onPushSubscriptionDidChange * Use current and previous instead of to and from * No other logic changes, only naming
nan-li
requested review from
emawby,
jkasten2,
shepherd-l and
jennantilla
and removed request for
emawby
April 28, 2023 20:41
* Rename click block to `OSInAppMessageClickListener` * Rename `setClickHandler` to `addClickListener` * Add a remove method for the click listener * OSInAppMessageAction has basically been renamed to OSInAppMessageClickResult * OSInAppMessageClickEvent will be passed to developers instead of OSInAppMessageAction and the event will contain an in app message and a click result.
OSInAppMessageDelegate and handleMessageAction not used by anything
* We have some legacy logic about IAM direct influence but if there are multiple click listeners added, we only want this to update once, and not for every listener.
* Rename setNotificationOpenedHandler -> addClickListener, removeClickListener * Rename object `OSNotificationOpenedResult` -> `OSNotificationClickEvent` * Rename object `OSNotificationAction` -> `OSNotificationClickResult` * Support having multiple listeners
…ener_api [5.0.0] Notification Click Listener - API update
[5.0.0] IAM Click Listener - API update
emawby
approved these changes
May 1, 2023
Merged
nan-li
pushed a commit
that referenced
this pull request
Oct 30, 2023
…ver_api [5.0.0] Push Subscription Observer - API update
nan-li
pushed a commit
that referenced
this pull request
Oct 30, 2023
…ver_api [5.0.0] Push Subscription Observer - API update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Push Subscription Observer - API update.
Details
Motivation
Push Subscription Observer - API update.
Scope
OSPushSubscriptionStateChanges
toOSPushSubscriptionChangedState
onOSPushSubscriptionChanged
toonPushSubscriptionDidChange
current
andprevious
instead ofto
andfrom
Public API
Testing
Manual testing
Tested on Physical iPhone 13 with iOS 16.x
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is