[5.0.0] Fixes to detecting native permissions #1229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes to sending permission change information and notification types to the user module.
Details
Motivation
The SDK was behaving oddly and getting into states where the
enabled
flag does not match thenotification_types
when an update subscription request is sent to the server. This happens when permissions are changed on the operating system level, and then returning to the app. It also seems like when returning to the app before these changes, we get the notification settings but too early and it contains the old information. These PR changes seem to remedy the problem mentioned.Scope
reachable
property separately.Known Issues
optOut
is called. The push subscription observer is not fired in this case.optOut
was also called. CallingoptIn
does not change thenotification_types
from-2
. This does not effect behavior.Testing
Manual testing
Example app with iPhone 13 on iOS 16.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is