Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes when failing to download Notification attachments #1029

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Fix crashes when failing to download Notification attachments #1029

merged 1 commit into from
Dec 14, 2021

Commits on Dec 14, 2021

  1. Putting try catch around fileHandle writeData 

    For iOS 13+ devices we will now use writeData:error: which returns a boolean and populates the NSError parameter with the failure reason if it  fails.

For < iOS 13 we will place a try catch around writeData: to avoid crashes.

In both cases we will log the failure reason. Note that this is logged on the NotificationServiceExtension process not the main app process.
    @emawby
    emawby committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    021f274 View commit details
    Browse the repository at this point in the history