Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump firebase-messaging to 24.0.0 #2149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions OneSignalSDK/onesignal/notifications/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,22 @@ dependencies {

compileOnly('com.amazon.device:amazon-appstore-sdk:[3.0.1, 3.0.99]')

// firebase-messaging:21.0.0 introduces FirebaseMessaging.getToken API
// firebase-messaging:23.0.0 incoporates fix for SecurityException: Not allowed to bind to service
// NOTE: firebase-messaging:24.0.0 requires customer's project to use
// compileSdkVersion 34 or higher.
api('com.google.firebase:firebase-messaging') {
version {
require '[21.0.0, 23.4.99]'
prefer '23.4.0'
require '[23.0.8, 24.0.99]'
prefer '24.0.0'
}
}
// Needed for GoogleApiAvailability
// Using compileOnly as firebase-messaging already includes this as a
// runtime dependency and we don't want to change what version is used in
// the customer's app. (firebase-messaging:24.0.0 is when this dependency
// changed to runtime)
// NOTE: If you change the firebase-messaging version you may need to
// bump this version if you get a compile error when building the SDK.
compileOnly('com.google.android.gms:play-services-base:18.0.1')

// Huawei PushKit
// KEEP as "compileOnly", so OneSignal isn't a direct dependency in the POM file.
Expand Down
Loading