[Tests] Switch to kotest-extensions-android #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move off our custom patched kotest-extensions-robolectric to the kotest-extensions-android library. This is a newly released library based off the patches we shared with the original developer. Switching over to kotest-extensions-android means we can remove this complexity from our project and can easily update the library to get fixes. We had to bump our minSdkVersion to 21 (Android 5.0) to use this library however we only officially supported Android 5.0 and newer since v5 of our SDK anyway.
nan-li
approved these changes
Mar 12, 2024
Base automatically changed from
fix/always-initWithContext-on-process-entry-points
to
main
March 12, 2024 17:40
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
In our tests, move off our locally patched
kotest-extensions-robolectrictokotest-extensions-android.Details
Motivation
Using a locally patch library makes our tests more complex and harder to get patches when fixes are released.
Scope
Affects tests using robolectric. Also bump our Android Min SDK to 21 (Android 5.0) as required by the new library.
Background
We worked with the of the developers who worked on
kotest-extensions-robolectricto get our patches to into a newkotest-extensions-androidlibrary. Our discussion in LeoColman/kotest-android#2Testing
Unit testing
Scope above covers this.
Manual testing
Ensured the example app still builds after our Android Min SDK bump.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is