Fix crash from missing operationExecutor in OperationModelStore create #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
requested changes
Sep 21, 2023
| RefreshUserOperationExecutor.REFRESH_USER -> RefreshUserOperation() | ||
| UpdateUserOperationExecutor.SET_TAG -> SetTagOperation() | ||
| UpdateUserOperationExecutor.DELETE_TAG -> DeleteTagOperation() | ||
| UpdateUserOperationExecutor.SET_PROPERTY -> SetPropertyOperation() | ||
| UpdateUserOperationExecutor.TRACK_SESSION_START -> TrackSessionStartOperation() | ||
| UpdateUserOperationExecutor.TRACK_SESSION_END -> TrackSessionEndOperation() | ||
| UpdateUserOperationExecutor.TRACK_PURCHASE -> TrackPurchaseOperation() | ||
| else -> throw Exception("Unrecognized operation: $operationName") |
There was a problem hiding this comment.
I think we should still throw, otherwise it will make finding the root cause much harder later.
There was a problem hiding this comment.
Agreed I reverted this change
I removed throwing from create for non-singleton model stores. I kept throw if a singleton model store is unable to create its model.
emawby
force-pushed
the
fix/crash_on_login_from_user_sub
branch
from
1878642
to
b65c008
Compare
jkasten2
approved these changes
Sep 21, 2023
Merged
1 task
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
Fix crash from missing operationExecutor in OperationModelStore create
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
Fix crash from missing operationExecutor in OperationModelStore create
jinliu9508
pushed a commit
that referenced
this pull request
Feb 6, 2024
Fix crash from missing operationExecutor in OperationModelStore create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed throwing from create for non-singleton model stores. I kept throw if a singleton model store is unable to create its model.
Description
One Line Summary
Fix a crash when the login user from subscription operation is being read from the cache.
Details
fixes #1814
The OperationModelStore did not account for the
LoginUserFromSubscriptionOperationoperation when creating operations from JSON and would throw an exception.This create method can no longer throw an exception even if it doesn't find the operation.
Motivation
Fix crash
Scope
cached login operation
Testing
Unit testing
OPTIONAL - Explain unit tests added, if not clear in the code.
Manual testing
Tested on a physical device.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is