[5.0.0] Fix canRequestPermission always returning true #1798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix canRequestPermission always returning true.
Details
Motivation
Addresses #1792 where canRequestPermission always returns true, even if user has already accepted the push prompt.
Scope
PreferenceStores updated when a user grants push permission. Key renamed to PREFS_OS_USER_RESOLVED_PERMISSION_PREFIX for increased clarity.
Testing
Manual testing
Tested that new value is updated in PreferenceStores and
canRequestPermission
successfully returns the correct boolean, depending on user behavior.Affected code checklist
Checklist
Overview
Testing
Final pass
This change is