Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.0] Fix canRequestPermission always returning true #1798

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Aug 9, 2023

Description

One Line Summary

Fix canRequestPermission always returning true.

Details

Motivation

Addresses #1792 where canRequestPermission always returns true, even if user has already accepted the push prompt.

Scope

PreferenceStores updated when a user grants push permission. Key renamed to PREFS_OS_USER_RESOLVED_PERMISSION_PREFIX for increased clarity.

Testing

Manual testing

Tested that new value is updated in PreferenceStores and canRequestPermission successfully returns the correct boolean, depending on user behavior.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby merged commit b8441cc into user-model/main Aug 10, 2023
1 check failed
@emawby emawby deleted the fix/canRequestPermission_returns_true branch August 10, 2023 01:12
@nan-li nan-li mentioned this pull request Aug 10, 2023
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
…rns_true

[5.0.0] Fix canRequestPermission always returning true
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
…rns_true

[5.0.0] Fix canRequestPermission always returning true
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
…rns_true

[5.0.0] Fix canRequestPermission always returning true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants