Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.0] Make subscribers in EventProducer synchronized #1796

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Aug 7, 2023

Description

One Line Summary

Address ConcurrentModificationException crash by making subscribers in EventProducer synchronized

Details

Motivation

Customer issue of ConcurrentModificationException reported by Firebase Crashlytics while registering for push notifications.

Scope

Crash occurs while iterating over subscribers list in EventProducer.

Testing

Unit testing

No unit testing used for this fix. Future unit test could be written to create a multithreading environment.

Manual testing

Unable to reproduce original crash. Tested branch builds and push notifications registration is successful.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

This fixes a concurrentmodificationexception
@emawby emawby merged commit aed2897 into user-model/main Aug 8, 2023
1 check failed
@emawby emawby deleted the fix/event_producer_crash branch August 8, 2023 18:00
@nan-li nan-li mentioned this pull request Aug 10, 2023
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
[5.0.0] Make subscribers in EventProducer synchronized
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
[5.0.0] Make subscribers in EventProducer synchronized
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
[5.0.0] Make subscribers in EventProducer synchronized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants