[User model] notification/subscription alignment #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use SubscriptionStatus enum for subscription status across the codebase. * IUserManager.subscriptions.push can no longer be null. If there isn't a push subscription a "dummy" one is now returned. * Add `fallbackToSettings` parameter for `ILocationManager.requestPermission` and `INotificationsManager.requestPermission` * Renamed `INotificationsManager.permissionsStatus` to `permission` and made it a simple Boolean. * Added `INotificationsManager.canRequestPermission` as a flag to indicate when permissions can be requested. * Added `ISubscription.addChangeHandler` to allow user to listen for changes to the subscription.
brismithers
deleted the
user-model/notification-subscription-alignment
branch
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
…ription-alignment [User model] notification/subscription alignment
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
…ription-alignment [User model] notification/subscription alignment
jinliu9508
pushed a commit
that referenced
this pull request
Feb 6, 2024
…ription-alignment [User model] notification/subscription alignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fallbackToSettingsparameter forILocationManager.requestPermissionandINotificationsManager.requestPermissionINotificationsManager.permissionsStatustopermissionand made it a simple Boolean.INotificationsManager.canRequestPermissionas a flag to indicate when permissions can be requested.ISubscription.addChangeHandlerto allow user to listen for changes to the subscription.This change is