Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Model] Modularize IAM/Notification/Location #1678

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

brismithers
Copy link
Contributor

@brismithers brismithers commented Oct 25, 2022

  • Move IAM/Notification/Location to their own gradle modules. AndroidManifest/proguard has now been split across the 4 modules.
  • Load modules dynamically using reflection within OneSignalImpl, falling back to "Misconfigured" versions if the modules weren't specified in the application.
  • Make internal classes required by a OS module no longer defined as internal (but keep in internal namespace).

This change is Reviewable

* Move IAM/Notification/Location to their own gradle modules. AndroidManifest/proguard has now been split across the 4 modules.
* Load modules dynamically using reflection within OneSignalImpl, falling back to "Misconfigured" versions if the modules weren't specified in the application.
* Make internal classes required by a OS module no longer defined as `internal` (but keep in internal namespace).
@brismithers brismithers merged commit 698b14f into user-model/main Oct 31, 2022
@brismithers brismithers deleted the user-model/gradle-modularization branch October 31, 2022 16:16
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
[User Model] Modularize IAM/Notification/Location
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
[User Model] Modularize IAM/Notification/Location
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
[User Model] Modularize IAM/Notification/Location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant