[User Model] notification_types and model event rework #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update `ISingletonModelStore.get()` function to be `ISingletonModelStore.model` property * Rework the model store change event system to always fire, using tags to differentiate why changes occurred. * Add `SubscriptionModel.status` to capture the subscription status, for when retrieving push token fails for some reason. * Drive event callback when app killed during request notification permission activity.
brismithers
deleted the
user-model/notification-types-model-event-rework
branch
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
…-model-event-rework [User Model] notification_types and model event rework
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
…-model-event-rework [User Model] notification_types and model event rework
jinliu9508
pushed a commit
that referenced
this pull request
Feb 6, 2024
…-model-event-rework [User Model] notification_types and model event rework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISingletonModelStore.get()function to beISingletonModelStore.modelpropertySubscriptionModel.statusto capture the subscription status, for when retrieving push token fails for some reason.This change is