Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SQLiteDatabaseLockedException #1109

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Fix SQLiteDatabaseLockedException #1109

merged 1 commit into from
Aug 10, 2020

Conversation

Jeasmine
Copy link
Contributor

@Jeasmine Jeasmine commented Aug 4, 2020 •
edited by jkasten2
Loading

  • Synchronize database due to differents threads trying to modify database
  • Remove database access from other classes that are not OneSignalDBHelper
  • Create query, insert, update, delete methods on OneSignalDBHelper
  • Make OneSignalDBHelper the only responsible of altering db

This change is Reviewable

@Jeasmine Jeasmine force-pushed the fix/synchronize-db branch 2 times, most recently from e8c6fed to 445f69c Compare August 4, 2020 16:26
jkasten2
jkasten2 requested changes Aug 4, 2020
View reviewed changes
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the code clean done in this PR to remove all the try-catch from the spots were DB writes where happening and now all lives in the OneSignalDb itself.

OneSignalSDK/onesignal/src/main/java/com/onesignal/NotificationBundleProcessor.java Show resolved Hide resolved
OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignalDb.java Outdated Show resolved Hide resolved
OneSignalSDK/unittest/src/test/java/com/test/onesignal/GenerateNotificationRunner.java Outdated Show resolved Hide resolved
@Jeasmine
Fix SQLiteDatabaseLockedException
f6bd285 
  * Synchronize database due to differents threads trying to modify database
  * Remove database access from other classes that are not OneSignalDBHelper
  * Create query, insert, update, delete methods on OneSignalDBHelper
  * Make OneSignalDBHelper the only responsible of altering db
@Jeasmine Jeasmine merged commit f6b9ca6 into master Aug 10, 2020
@Jeasmine Jeasmine deleted the fix/synchronize-db branch August 10, 2020 15:03
@jkasten2 jkasten2 mentioned this pull request Aug 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkasten2 jkasten2 jkasten2 approved these changes

@mikechoch mikechoch mikechoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jeasmine @jkasten2 @mikechoch