-
Notifications
You must be signed in to change notification settings - Fork 368
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2012 from OneSignal/fix/service-provide-thread-sa…
…fety Make ServiceBuilder.getService thread safe
- Loading branch information
Showing
2 changed files
with
63 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
OneSignalSDK/onesignal/core/src/test/java/com/onesignal/common/ServiceProviderTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
package com.onesignal.common | ||
|
||
import com.onesignal.common.services.ServiceBuilder | ||
import com.onesignal.common.services.ServiceProvider | ||
import io.kotest.core.spec.style.FunSpec | ||
import io.kotest.matchers.types.shouldBeSameInstanceAs | ||
import java.util.concurrent.LinkedBlockingQueue | ||
|
||
internal interface IMyTestInterface | ||
|
||
internal class MySlowConstructorClass : IMyTestInterface { | ||
init { | ||
// NOTE: Keep these println calls, otherwise Kotlin optimizes | ||
// something which cases the test not fail when it should. | ||
println("MySlowConstructorClass BEFORE") | ||
Thread.sleep(10) | ||
println("MySlowConstructorClass AFTER") | ||
} | ||
} | ||
|
||
class ServiceProviderTest : FunSpec({ | ||
|
||
fun setupServiceProviderWithSlowInitClass(): ServiceProvider { | ||
val serviceBuilder = ServiceBuilder() | ||
serviceBuilder.register<MySlowConstructorClass>().provides<IMyTestInterface>() | ||
return serviceBuilder.build() | ||
} | ||
|
||
test("getService is thread safe") { | ||
val services = setupServiceProviderWithSlowInitClass() | ||
|
||
val queue = LinkedBlockingQueue<IMyTestInterface>() | ||
Thread { | ||
queue.add(services.getService<IMyTestInterface>()) | ||
}.start() | ||
Thread { | ||
queue.add(services.getService<IMyTestInterface>()) | ||
}.start() | ||
|
||
val firstReference = queue.take() | ||
val secondReference = queue.take() | ||
firstReference shouldBeSameInstanceAs secondReference | ||
} | ||
}) |