Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LSP] language server emits protocolVersion instead of jsonrpc #1312

Closed
razzmatazz opened this issue Oct 7, 2018 · 4 comments
Closed

[LSP] language server emits protocolVersion instead of jsonrpc #1312

razzmatazz opened this issue Oct 7, 2018 · 4 comments
Labels
lsp

Comments

@razzmatazz
Copy link
Contributor

razzmatazz commented Oct 7, 2018 •
edited
Loading

I see this was fixed in OmniSharp/csharp-language-server-protocol#98 – would it be possible update src/Omnisharp.LanguageServerProtocol to use the updated version?

At the moment the issue is that lsp-mode from emacs fails to read response from the current implementation due to the missing jsonrpc property.

Related to emacs-lsp/lsp-mode#415
@razzmatazz razzmatazz changed the title [LSP] language server mode emits protocolVersion instead of jsonrpc [LSP] language server emits protocolVersion instead of jsonrpc Oct 7, 2018
@Daniel-V1 Daniel-V1 mentioned this issue Nov 27, 2018
Closed
@Aayush04
Copy link

I am getting the same issue. Any idea when it will be getting fixed in this repository Or how to get latest OmniSharp.LanguageServerProtocol.dll in the omnisharp-roslyn ?

@ilohmar
Copy link

ilohmar commented Jan 23, 2019 •
edited
Loading

Ping.. same issue here with https://github.com/joaotavora/eglot..

@ilohmar ilohmar mentioned this issue Jan 23, 2019
Closed
@razzmatazz razzmatazz mentioned this issue Mar 1, 2019
Open
@filipw filipw added the lsp label Mar 12, 2019
@joranvar joranvar mentioned this issue Mar 22, 2019
Closed
@ilohmar
Copy link

ilohmar commented Mar 25, 2019

It seems this can be closed with release 1.32.11..

@razzmatazz
Copy link
Contributor Author

@ilohmar right, this works now as i have checked with emacs-lsp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lsp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@razzmatazz @filipw @ilohmar @Aayush04