Update deprecated code #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marcsosduma
commented
Sep 23, 2023
marcsosduma
commented
- Migrate from TSLint to ESLint
- Update the deprecated package name 'vscode-debugadapter' and 'debugadapter-testsupport'.
GitMensch
suggested changes
Sep 26, 2023
There was a problem hiding this comment.
Can you please rebase? It seems that part of the changes are already part of master (which is one of the reasons for the merge conflict which prevents us to directly merge this in).
Other than that: please check the minimal version dependencies, they are very likely much too high.
| It represents the closest reasonable ESLint configuration to this | ||
| project's original TSLint configuration. | ||
|
|
||
| We recommend eventually switching this configuration to extend from |
There was a problem hiding this comment.
Did you checked that?
Please adjust the comment accordingly.
There was a problem hiding this comment.
@marcsosduma What about this comment?
|
Good evening, Simon! OK. I will check the points you mentioned. Thank you. |
* Update the deprecated package name 'vscode-debugadapter' and 'debugadapter-testsupport'. Changes: (#134) * Allow viewing of variables with the - character in the name. * Enable hovering on child variables. * Display debug output in the VSCode terminal. * Set XTERM variable to the correct display during debugging with the GDB TTY option. * Utilize gdbtty for debugging on WSL and SSH (Windows -> Linux). * Perform 'stepOver' in subroutines called by 'PERFORM' statement. * Support 'stepInto'/'stepOut' in subroutines called by 'PERFORM' statement. * Run Gdbtty with Ctrl-F5. * Provide support for symbolic link directories on linux. Maybe, just maybe
GitMensch
suggested changes
Oct 1, 2023
| It represents the closest reasonable ESLint configuration to this | ||
| project's original TSLint configuration. | ||
|
|
||
| We recommend eventually switching this configuration to extend from |
There was a problem hiding this comment.
@marcsosduma What about this comment?
GitMensch
suggested changes
Oct 2, 2023
|
LGTM, so let's wait for @OlegKunitsyn to merge that in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.