From 73adc9f7925659c5d2b34d074c6bbe98e8842cdd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sidney=20San=20Mart=C3=ADn?= <sidney@okcupid.com>
Date: Fri, 21 Feb 2014 17:29:05 -0500
Subject: [PATCH] Make rxx_replace behave correctly with zero-length matches

`"0123"|replace(r{^0*}, '')` no longer evaluates to the empty string
---
 libpub/rxx.C | 57 +++++++++++++++++++++++-----------------------------
 1 file changed, 25 insertions(+), 32 deletions(-)

diff --git a/libpub/rxx.C b/libpub/rxx.C
index 81ce6ef6..6bbe8742 100644
--- a/libpub/rxx.C
+++ b/libpub/rxx.C
@@ -195,45 +195,38 @@ str
 rxx_replace_2 (str input, rxx pat, str repl_str)
 {
   repl_t repl;
-  str ret;
   if (!repl.parse (repl_str)) {
     warn << "XX cannot parse replacement string: " << repl_str << "\n";
-  } else {
-    const char *p = input.cstr();
-    const char *const e = p + input.len ();
-    strbuf b;
-    bool go = true;
-    bool err = false;
-
-    // check p < e to see that we're not dealing with an empty
-    // string (especially since x? matches "").
-    while (go && !err && p < e) {
-
-      if (!pat._exec (p, e - p, 0)) { 
-	warn << "XX regex execution failed\n";
-	err = true; 
-      }
-      
-      else if (!pat.success ()) { go = false; }
-
-      else {
-	str pre = str (p, pat.start (0));
-	strbuf_output (b, pre);
-	repl.output (b, p, pat);
-	p += max (pat.end (0), 1);
-      }
-
+    return nullptr;
+  }
+  strbuf b;
+  int offset = 0;
+
+  while (pat._exec(input.cstr(), input.len(), 0, offset) && pat.success()) { 
+
+    if (pat.start(0) == pat.end(0)) {
+        if (offset < input.len()) {
+            repl.output (b, input.cstr(), pat);
+            b.copy(input.cstr() + offset, pat.start(0) - offset + 1);
+            offset++;
+            continue;
+        } else {
+            repl.output (b, input.cstr(), pat);
+            break;
+        }
     }
 
-    if (p < e && !err) {
-      str post = str (p, e - p);
-      strbuf_output (b, post);
-    }
+    b.copy(input.cstr() + offset, pat.start(0) - offset);
+    repl.output (b, input.cstr(), pat);
+    offset = pat.end(0);
 
-    if (!err) { ret = b; }
+  }
 
+  if (offset < input.len()) {
+      b.copy(input.cstr() + offset, input.len() - offset);
   }
-  return ret;
+
+  return b;
 }
 
 //-----------------------------------------------------------------------