From 31c0768768865c823052024907b8b7f477369b53 Mon Sep 17 00:00:00 2001 From: Jeremy <297323986@qq.com> Date: Thu, 12 Sep 2024 20:10:41 +0800 Subject: [PATCH 1/2] Wait for the deployment of upgrade executor (#219) Co-authored-by: gzeon --- scripts/deploymentUtils.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/deploymentUtils.ts b/scripts/deploymentUtils.ts index cb8f9c4c..f633c658 100644 --- a/scripts/deploymentUtils.ts +++ b/scripts/deploymentUtils.ts @@ -228,6 +228,7 @@ export async function deployAllContracts( ) const rollupUser = await deployContract('RollupUserLogic', signer, [], verify) const upgradeExecutor = await deployUpgradeExecutor(signer) + await upgradeExecutor.deployTransaction.wait() const validatorUtils = await deployContract( 'ValidatorUtils', signer, From 2376ee73a023954de53d9d86b5c0ff336b8e553d Mon Sep 17 00:00:00 2001 From: gzeon Date: Thu, 12 Sep 2024 20:36:42 +0800 Subject: [PATCH 2/2] docs: explain arbOSVersion offset (#245) --- src/precompiles/ArbSys.sol | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/precompiles/ArbSys.sol b/src/precompiles/ArbSys.sol index 4e7a8f41..56c0bad9 100644 --- a/src/precompiles/ArbSys.sol +++ b/src/precompiles/ArbSys.sol @@ -29,7 +29,8 @@ interface ArbSys { function arbChainID() external view returns (uint256); /** - * @notice Get internal version number identifying an ArbOS build + * @notice Get internal version number identifying an ArbOS build, this is `55 + nitroArbOS version number` + * e.g. on ArbOS 31 this would return 86. This is the only function that have the 55 offset. * @return version number as int */ function arbOSVersion() external view returns (uint256);