Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #254, add integration test for options in factory logic #256

Closed
Ocramius opened this issue Aug 24, 2015 · 5 comments
Closed

Revert #254, add integration test for options in factory logic #256

Ocramius opened this issue Aug 24, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@Ocramius
Copy link
Owner

#254 should be reverted, as the change actually removes functionality.

@malukenho
Copy link
Collaborator

@Ocramius what functionality was removed? If it was removed I think we have bad tests for this particular one.

@Ocramius Ocramius changed the title Revert #254 Revert #254, add integration test for options in factory logic Aug 24, 2015
@Ocramius
Copy link
Owner Author

@malukenho see discussion on #254 - need a unit test that expects the proxy generator to be given appropriate proxy options

@Ocramius
Copy link
Owner Author

Note: already reverted in Ocramius/ProxyManager#079399916eb7fba57aed709de2d63f104c696673 - now needs to be tested.

@localheinz
Copy link
Contributor

@malukenho @Ocramius

Sorry!

@Ocramius
Copy link
Owner Author

@localheinz no problem, you couldn't possibly know :-)

I considered changing the interface, but the BC break was a bit too big. Wondering if I can do it for 2.x :-\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants